netdev - Re: [PATCH bpf-next v3] xsk: fix xsk_build_skb() error: 'skb' dereferencing possible ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 30 Aug 2023 07:00:22 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Tirthendu Sarkar <tirthendu.sarkar@...el.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, bjorn@...nel.org,
 magnus.karlsson@...el.com, maciej.fijalkowski@...el.com,
 jonathan.lemon@...il.com, davem@...emloft.net, kuba@...nel.org,
 pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
 martin.lau@...ux.dev, dan.carpenter@...aro.org, sdf@...gle.com
Subject: Re: [PATCH bpf-next v3] xsk: fix xsk_build_skb() error: 'skb'
 dereferencing possible ERR_PTR()

Hello:

This patch was applied to bpf/bpf.git (master)
by Daniel Borkmann <daniel@...earbox.net>:

On Wed, 23 Aug 2023 20:17:13 +0530 you wrote:
> Currently, xsk_build_skb() is a function that builds skb in two possible
> ways and then is ended with common error handling.
> 
> We can distinguish four possible error paths and handling in xsk_build_skb():
>  1. sock_alloc_send_skb fails: Retry (skb is NULL).
>  2. skb_store_bits fails : Free skb and retry.
>  3. MAX_SKB_FRAGS exceeded: Free skb, cleanup and drop packet.
>  4. alloc_page fails for frag: Retry page allocation w/o freeing skb
> 
> [...]

Here is the summary with links:
  - [bpf-next,v3] xsk: fix xsk_build_skb() error: 'skb' dereferencing possible ERR_PTR()
    https://git.kernel.org/bpf/bpf/c/9d0a67b9d42c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html