netdev - Re: [PATCH bpf] bpf: sockmap, fix preempt_rt splat when using raw_spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3b0b23f-4cdf-75a6-2781-a618fe65fcec@iogearbox.net>
Date: Wed, 30 Aug 2023 10:03:51 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: John Fastabend <john.fastabend@...il.com>, bpf@...r.kernel.org
Cc: jakub@...udflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf] bpf: sockmap, fix preempt_rt splat when using
 raw_spin_lock_t

On 8/30/23 7:35 AM, John Fastabend wrote:
[...]
>   net/core/sock_map.c | 36 ++++++++++++++++++------------------
>   1 file changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/net/core/sock_map.c b/net/core/sock_map.c
> index 8f07fea39d9e..cb11750b1df5 100644
> --- a/net/core/sock_map.c
> +++ b/net/core/sock_map.c
> @@ -18,7 +18,7 @@ struct bpf_stab {
>   	struct bpf_map map;
>   	struct sock **sks;
>   	struct sk_psock_progs progs;
> -	raw_spinlock_t lock;
> +	spinlock_t lock;
>   };

Looks good to me, and I agree that it's better to take this direction rather
than converting both to raw_spinlock_t if there is no good reason for it.
Thanks for looking into it, applied!