netdev - RE: [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 30 Aug 2023 09:17:22 +0000
From: Sriram Yagnaraman <sriram.yagnaraman@....tech>
To: Ido Schimmel <idosch@...sch.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>, "David S
 . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, David Ahern
	<dsahern@...nel.org>, Ido Schimmel <idosch@...dia.com>, Shuah Khan
	<shuah@...nel.org>, Petr Machata <petrm@...dia.com>
Subject: RE: [PATCH net v3 3/3] selftests: fib_tests: Add multipath list
 receive tests



> -----Original Message-----
> From: Ido Schimmel <idosch@...sch.org>
> Sent: Monday, 28 August 2023 17:24
> To: Sriram Yagnaraman <sriram.yagnaraman@....tech>; kuba@...nel.org;
> pabeni@...hat.com
> Cc: netdev@...r.kernel.org; linux-kselftest@...r.kernel.org; David S . Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; David Ahern
> <dsahern@...nel.org>; Ido Schimmel <idosch@...dia.com>; Shuah Khan
> <shuah@...nel.org>; Petr Machata <petrm@...dia.com>
> Subject: Re: [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive
> tests
> 
> On Mon, Aug 28, 2023 at 01:32:21PM +0200, Sriram Yagnaraman wrote:
> > The test uses perf stat to count the number of fib:fib_table_lookup
> > tracepoint hits for IPv4 and the number of fib6:fib6_table_lookup for
> > IPv6. The measured count is checked to be within 5% of the total
> > number of packets sent via veth1.
> >
> > Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@....tech>
> 
> I just tested this with a debug config and noticed that the single path test is not
> very stable. It's not really related to the bug fix, so I think you can simply
> remove it.
> 

Sent v4 with just the multipath test and rebased to latest after the merge with net-next. 

If it is OK with all of you here, should I try to improve this test to verify TCP resets don't happen when the nexthop is in a multipath group, perhaps using iperf3? I can send another patch if/when I get something working.