netdev - Re: [PATCH net] net: fib: avoid warn splat in flow dissector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZO9WVHlbL7a0qwxx@shredder>
Date: Wed, 30 Aug 2023 17:46:44 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Florian Westphal <fw@...len.de>
Cc: netdev@...r.kernel.org, Stanislav Fomichev <sdf@...gle.com>,
	David Ahern <dsahern@...nel.org>, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net] net: fib: avoid warn splat in flow dissector

On Wed, Aug 30, 2023 at 01:00:37PM +0200, Florian Westphal wrote:
> New skbs allocated via nf_send_reset() have skb->dev == NULL.
> 
> fib*_rules_early_flow_dissect helpers already have a 'struct net'
> argument but its not passed down to the flow dissector core, which
> will then WARN as it can't derive a net namespace to use:
> 
>  WARNING: CPU: 0 PID: 0 at net/core/flow_dissector.c:1016 __skb_flow_dissect+0xa91/0x1cd0
>  [..]
>   ip_route_me_harder+0x143/0x330
>   nf_send_reset+0x17c/0x2d0 [nf_reject_ipv4]
>   nft_reject_inet_eval+0xa9/0xf2 [nft_reject_inet]
>   nft_do_chain+0x198/0x5d0 [nf_tables]
>   nft_do_chain_inet+0xa4/0x110 [nf_tables]
>   nf_hook_slow+0x41/0xc0
>   ip_local_deliver+0xce/0x110
>   ..
> 
> Cc: Stanislav Fomichev <sdf@...gle.com>
> Cc: David Ahern <dsahern@...nel.org>
> Cc: Ido Schimmel <idosch@...dia.com>
> Fixes: 812fa71f0d96 ("netfilter: Dissect flow after packet mangling")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217826
> Signed-off-by: Florian Westphal <fw@...len.de>

Reviewed-by: Ido Schimmel <idosch@...dia.com>

Thanks!