netdev - Re: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 30 Aug 2023 16:48:31 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Lukasz Majewski <lukma@...x.de>, Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew@...n.ch>, davem@...emloft.net,
	Woojung Huh <woojung.huh@...rochip.com>,
	Vladimir Oltean <olteanv@...il.com>, Tristram.Ha@...rochip.com,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	UNGLinuxDriver@...rochip.com,
	Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata
 (DS80000754C)

On Wed, Aug 30, 2023 at 03:38:55PM +0100, Russell King (Oracle) wrote:
> On Wed, Aug 30, 2023 at 04:26:50PM +0200, Oleksij Rempel wrote:
> > @Lukasz,
> > 
> > can you please try to set eee_broken_modes to all-ones. Somewhat like
> > this:
> > ksz9477_config_init()
> > ...
> >    ...quirks...
> > 
> >    if (phydev->dev_flages & .. NO_EEE...)
> >        phydev->eee_broken_modes = -1;
> 
> That's fine in config_init().
> 
> >    err = genphy_restart_aneg(phydev);
> 
> That isn't necessary, and in any case, calling it will just cause the
> AN enable and AN restart bits in BMCR to be set, nothing will be
> reprogrammed.

ack. It is already existing code, see:
https://elixir.bootlin.com/linux/v6.5/source/drivers/net/phy/micrel.c#L1822

Setting eee_broken_modes probably can be done at any plaice in this function.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |