netdev - Re: [PATCH net-next v2] veth: Fixing transmit return status for dropped packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a3317b3-c519-750e-710f-2567e1a5c508@6wind.com>
Date: Thu, 31 Aug 2023 14:43:30 +0200
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Liang Chen <liangchen.linux@...il.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] veth: Fixing transmit return status for
 dropped packets

Le 31/08/2023 à 14:11, Liang Chen a écrit :
> The veth_xmit function returns NETDEV_TX_OK even when packets are dropped.
> This behavior leads to incorrect calculations of statistics counts, as
> well as things like txq->trans_start updates.
> 
> Fixes: e314dbdc1c0d ("[NET]: Virtual ethernet device driver.")
> Signed-off-by: Liang Chen <liangchen.linux@...il.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

This is a fix, the patch should target the 'net' tree, not the 'net-next' tree
(which is closed btw: https://patchwork.hopto.org/net-next.html).


Regards,
Nicolas