netdev - Re: [PATCH bpf-next v3 6/9] bpftool: Add support for cgroup unix socket address hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3ba2fc4-2210-418c-ac56-6b3af7ef1cce@isovalent.com>
Date: Thu, 31 Aug 2023 17:58:23 +0100
From: Quentin Monnet <quentin@...valent.com>
To: Daan De Meyer <daan.j.demeyer@...il.com>, bpf@...r.kernel.org
Cc: martin.lau@...ux.dev, kernel-team@...a.com, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next v3 6/9] bpftool: Add support for cgroup unix
 socket address hooks

On 31/08/2023 16:34, Daan De Meyer wrote:
> Add the necessary plumbing to hook up the new cgroup unix sockaddr
> hooks into bpftool.
> 
> Signed-off-by: Daan De Meyer <daan.j.demeyer@...il.com>
> ---
>  .../bpftool/Documentation/bpftool-cgroup.rst  | 23 ++++++++++++++-----
>  .../bpftool/Documentation/bpftool-prog.rst    | 10 ++++----
>  tools/bpf/bpftool/bash-completion/bpftool     | 14 +++++------
>  tools/bpf/bpftool/cgroup.c                    | 17 ++++++++------
>  tools/bpf/bpftool/prog.c                      |  9 ++++----
>  5 files changed, 45 insertions(+), 28 deletions(-)
> 
> diff --git a/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst b/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst
> index bd015ec9847b..19dba2b55246 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool-cgroup.rst

> @@ -98,25 +101,33 @@ DESCRIPTION
>  		  **device** device access (since 4.15);
>  		  **bind4** call to bind(2) for an inet4 socket (since 4.17);
>  		  **bind6** call to bind(2) for an inet6 socket (since 4.17);
> +		  **bindun** call to bind(2) for a unix socket (since 6.3);
I missed it earlier - kernel version (6.3) won't be correct, please
update it for the next iteration.

Bpftool changes look all good otherwise, thank you!

Acked-by: Quentin Monnet <quentin@...valent.com>