netdev - Re: [PATCH net] sfc: check for zero length in EF10 RX prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKeNw4pjUKmWf=VAEWK-X4JCnP2pJic_9Jb0Whne_4e0Q@mail.gmail.com>
Date: Thu, 31 Aug 2023 19:07:46 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: edward.cree@....com
Cc: linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, Edward Cree <ecree.xilinx@...il.com>, netdev@...r.kernel.org, 
	habetsm.xilinx@...il.com
Subject: Re: [PATCH net] sfc: check for zero length in EF10 RX prefix

On Thu, Aug 31, 2023 at 6:59 PM <edward.cree@....com> wrote:
>
> From: Edward Cree <ecree.xilinx@...il.com>
>
> When EF10 RXDP firmware is operating in cut-through mode, packet length
>  is not known at the time the RX prefix is generated, so it is left as
>  zero and RX event merging is inhibited to ensure that the length is
>  available in the RX event.  However, it has been found that in certain
>  circumstances the RX events for these packets still get merged,
>  meaning the driver cannot read the length from the RX event, and tries
>  to use the length from the prefix.
> The resulting zero-length SKBs cause crashes in GRO since commit
>  1d11fa696733 ("net-gro: remove GRO_DROP"), so add a check to the driver
>  to detect these zero-length RX events and discard the packet.
>
> Signed-off-by: Edward Cree <ecree.xilinx@...il.com>

Nice bug ;)

Thanks for this fix.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>