netdev - Re: [PATCH net] net/handshake: fix null-ptr-deref in handshake_nl_done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566a0f821ec2fdbcb6b31aae56e478c6d4d59fa3.camel@redhat.com>
Date: Thu, 31 Aug 2023 09:54:57 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>,  Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com, syzbot
	 <syzkaller@...glegroups.com>, Chuck Lever <chuck.lever@...cle.com>
Subject: Re: [PATCH net] net/handshake: fix null-ptr-deref in
 handshake_nl_done_doit()

On Mon, 2023-08-28 at 09:13 +0000, Eric Dumazet wrote:
> We should not call trace_handshake_cmd_done_err() if socket lookup has failed.

I think Chuck would like to have a tracepoint for all the possible
handshake_nl_done_doit() failures, but guess that could be added later
on net-next, possibly refactoring the arguments list (e.g. adding an
explicit fd arg, and passing explicitly a NULL sk).

> Also we should call trace_handshake_cmd_done_err() before releasing the file,
> otherwise dereferencing sock->sk can return garbage.
> 
> This also reverts 7afc6d0a107f ("net/handshake: Fix uninitialized local variable")

I can be low on coffee, but

	struct handshake_req *req = NULL;

is still there after this patch ?!?

Cheers,

Paolo