netdev - Re: [PATCH net,v2] wifi: mac80211: fix WARNING in ieee80211_link_info_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e96e981f58ca5bccf71952f76efe5e08a88f11d.camel@sipsolutions.net>
Date: Fri, 01 Sep 2023 11:19:35 +0200
From: Johannes Berg <johannes@...solutions.net>
To: shaozhengchao <shaozhengchao@...wei.com>,
 linux-wireless@...r.kernel.org,  netdev@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
 pabeni@...hat.com
Cc: weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net,v2] wifi: mac80211: fix WARNING in
 ieee80211_link_info_change_notify()

Hi,


> 	Do you mean it shouldn't be allowed to set mcast rate when dev
> is stopped,
> 

Probably?

>  as in the following code?
> 
> --- a/net/wireless/rdev-ops.h
> +++ b/net/wireless/rdev-ops.h
> @@ -1229,7 +1229,7 @@ rdev_set_mcast_rate(struct 
> cfg80211_registered_device *rdev,
>          int ret = -ENOTSUPP;
> 
>          trace_rdev_set_mcast_rate(&rdev->wiphy, dev, mcast_rate);
> -       if (rdev->ops->set_mcast_rate)
> +       if (rdev->ops->set_mcast_rate && netif_running(dev))
>                  ret = rdev->ops->set_mcast_rate(&rdev->wiphy, dev, 
> 

Certainly not. Please don't do random patches without looking at the
subsystem as a whole. If you don't want to take the time to understand
how things work in wireless, then better don't send patches at all.

johannes