netdev - Re: [PATCH bpf-next v2] selftests/bpf: fix a CI failure caused by vsock write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30dd8d7f-47f5-154b-25a4-ea2bb65d9235@iogearbox.net>
Date: Fri, 1 Sep 2023 11:38:35 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Xu Kuohai <xukuohai@...wei.com>, Xu Kuohai <xukuohai@...weicloud.com>,
 bpf@...r.kernel.org, netdev@...r.kernel.org
Cc: Bobby Eshleman <bobby.eshleman@...edance.com>
Subject: Re: [PATCH bpf-next v2] selftests/bpf: fix a CI failure caused by
 vsock write

On 9/1/23 10:38 AM, Xu Kuohai wrote:
> On 9/1/2023 4:22 PM, Daniel Borkmann wrote:
>> On 9/1/23 5:10 AM, Xu Kuohai wrote:
>>> From: Xu Kuohai <xukuohai@...wei.com>
[...]
>> Should the error path rather be ?
>>
>> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c b/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
>> index 2d3bf38677b6..8df8cbb447f1 100644
>> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
>> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
>> @@ -1454,7 +1454,7 @@ static int vsock_socketpair_connectible(int sotype, int *v0, int *v1)
>>
>>          if (poll_connect(c, IO_TIMEOUT_SEC) < 0) {
>>                  FAIL_ERRNO("poll_connect");
>> -               goto close_cli;
>> +               goto close_acc;
>>          }
>>
>>          *v0 = p;
>> @@ -1462,6 +1462,8 @@ static int vsock_socketpair_connectible(int sotype, int *v0, int *v1)
>>
>>          return 0;
>>
>> +close_acc:
>> +       close(p);
>>   close_cli:
>>          close(c);
>>   close_srv:
>>
>>
>> Let me know and I'll squash this into the fix.
>>
> 
> Right, the accepted connection should be closed, thanks.

Ok, done, pushed.