| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <831bc700-a9a2-7eda-e97b-e1d54dc806f9@oss.nxp.com> Date: Fri, 1 Sep 2023 14:58:12 +0300 From: "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com> To: Sabrina Dubroca <sd@...asysnail.net>, Radu Pirea <radu-nicolae.pirea@....com> Cc: "atenart@...nel.org" <atenart@...nel.org>, "andrew@...n.ch" <andrew@...n.ch>, "linux@...linux.org.uk" <linux@...linux.org.uk>, "hkallweit1@...il.com" <hkallweit1@...il.com>, "davem@...emloft.net" <davem@...emloft.net>, Sebastian Tobuschat <sebastian.tobuschat@....com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "richardcochran@...il.com" <richardcochran@...il.com>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [RFC net-next v2 5/5] net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag On 01.09.2023 13:07, Sabrina Dubroca wrote: ... > >>> And what happens in this case? >>> ip link add link eth0 type macsec offload phy >>> ip link set eth0 down >>> ip macsec add macsec0 rx sci ... >>> ip macsec add macsec0 tx sa 0 ... >>> # etc >>> ip link set eth0 up >>> >>> Will offload work with the current code? >> >> (the interface was up before) >> [root@...rm ~]# ip link add link end0 macsec0 type macsec encrypt on >> offload phy >> [root@...rm ~]# ip link set end0 down >> [root@...rm ~]# ip macsec add macsec0 rx port 1 address >> 00:01:be:be:ef:33 >> RTNETLINK answers: Operation not supported > > Where does that EOPNOTSUPP come from? nxp_c45_mdo_add_rxsc from this > version of the code can't return that, and macsec_add_rxsc also > shouldn't at this point. This is the source of -EOPNOTSUPP https://elixir.bootlin.com/linux/latest/source/drivers/net/macsec.c#L1928 -- Radu P.
Powered by blists - more mailing lists