netdev - Re: [PATCH iproute2] iplink_bridge: fix incorrect root id dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9439db7-5d1e-5a2d-399c-884e8661c0b9@blackwall.org>
Date: Sun, 3 Sep 2023 11:38:15 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: David Ahern <dsahern@...nel.org>,
 Stephen Hemminger <stephen@...workplumber.org>,
 Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH iproute2] iplink_bridge: fix incorrect root id dump

On 9/1/23 11:02, Hangbin Liu wrote:
> Fix the typo when dump root_id.
> 
> Fixes: 70dfb0b8836d ("iplink: bridge: export bridge_id and designated_root")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>   ip/iplink_bridge.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
> index 7e4e62c81c0c..462075295308 100644
> --- a/ip/iplink_bridge.c
> +++ b/ip/iplink_bridge.c
> @@ -499,7 +499,7 @@ static void bridge_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
>   	if (tb[IFLA_BR_ROOT_ID]) {
>   		char root_id[32];
>   
> -		br_dump_bridge_id(RTA_DATA(tb[IFLA_BR_BRIDGE_ID]), root_id,
> +		br_dump_bridge_id(RTA_DATA(tb[IFLA_BR_ROOT_ID]), root_id,
>   				  sizeof(root_id));
>   		print_string(PRINT_ANY,
>   			     "root_id",

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>