netdev - [PATCH net-next v3 2/6] net: bridge: Set strict_start_type for br

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 05 Sep 2023 13:47:19 +0200
From: Johannes Nixdorf <jnixdorf-oss@....de>
To: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, 
 David Ahern <dsahern@...il.com>, Eric Dumazet <edumazet@...gle.com>, 
 Florian Fainelli <f.fainelli@...il.com>, Ido Schimmel <idosch@...dia.com>, 
 Jakub Kicinski <kuba@...nel.org>, Nikolay Aleksandrov <razor@...ckwall.org>, 
 Oleksij Rempel <linux@...pel-privat.de>, Paolo Abeni <pabeni@...hat.com>, 
 Roopa Prabhu <roopa@...dia.com>, Shuah Khan <shuah@...nel.org>, 
 Vladimir Oltean <vladimir.oltean@....com>
Cc: bridge@...ts.linux-foundation.org, netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org, 
 Johannes Nixdorf <jnixdorf-oss@....de>
Subject: [PATCH net-next v3 2/6] net: bridge: Set strict_start_type for
 br_policy

Set any new attributes added to br_policy to be parsed strictly, to
prevent userspace from passing garbage.

Signed-off-by: Johannes Nixdorf <jnixdorf-oss@....de>
---
 net/bridge/br_netlink.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 05c5863d2e20..1dc4e1bce740 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -1217,6 +1217,7 @@ static size_t br_port_get_slave_size(const struct net_device *brdev,
 }

 static const struct nla_policy br_policy[IFLA_BR_MAX + 1] = {
+	[IFLA_BR_UNSPEC]	= { .strict_start_type = IFLA_BR_MCAST_QUERIER_STATE + 1 },
 	[IFLA_BR_FORWARD_DELAY]	= { .type = NLA_U32 },
 	[IFLA_BR_HELLO_TIME]	= { .type = NLA_U32 },
 	[IFLA_BR_MAX_AGE]	= { .type = NLA_U32 },

-- 
2.42.0