netdev - RE: [PATCH net] net: deal with integer overflows in kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b5aa733ab86401c966092e1e5567e65@AcuMS.aculab.com>
Date: Tue, 5 Sep 2023 12:44:56 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Eric Dumazet' <edumazet@...gle.com>
CC: Kyle Zeng <zengyhkyle@...il.com>, "David S . Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>, syzbot
	<syzkaller@...glegroups.com>, Kees Cook <keescook@...omium.org>, "Vlastimil
 Babka" <vbabka@...e.cz>
Subject: RE: [PATCH net] net: deal with integer overflows in kmalloc_reserve()

From: Eric Dumazet
> Sent: 05 September 2023 13:34
> 
> On Tue, Sep 5, 2023 at 2:27 PM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > On Tue, Sep 5, 2023 at 10:36 AM David Laight <David.Laight@...lab.com> wrote:
> > >
> > > From: Eric Dumazet
> > > > Sent: 05 September 2023 04:42
> > > ...
> > > > Again, I do not want this patch, I want to fix the root cause(s).
> > > >
> > > > It makes no sense to allow dev->mtu to be as big as 0x7fffffff and
> > > > ultimately allow size to be bigger than 0x80000000
> > >
> > > kmem_alloc_reserve() also needs fixing.
> >
> > Yes, this is what I said. Please provide a patch ?
> 
> Oops, I thought you were speaking about kmalloc_size_roundup()
> 
> kmalloc_reserve() is fine, all overflows must be taken care of before
> reaching it.

I was talking about roundup()

I'm in all the wrong place to generate a patch.
And having to send the emails from windows makes the procedure a
right PITA.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)