netdev - Re: [PATCH] vdpa: consume device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71c187a5-337c-46e9-8d88-35d288795fc8@amd.com>
Date: Thu, 7 Sep 2023 16:02:04 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Si-Wei Liu <si-wei.liu@...cle.com>, dsahern@...nel.org,
 stephen@...workplumber.org
Cc: allen.hubbe@....com, drivers@...sando.io, jasowang@...hat.com,
 mst@...hat.com, netdev@...r.kernel.org,
 virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] vdpa: consume device_features parameter

On 9/7/2023 1:41 PM, Si-Wei Liu wrote:
> 
> Hi David,
> 
> Why this patch doesn't get picked in the last 4 months? Maybe the
> subject is not clear, but this is an iproute2 patch. Would it be
> possible to merge at your earliest convenience?
> 
> PS, adding my R-b to the patch.

Maybe I aimed this at the wrong person?  I see that Stephen just 
announced the latest iproute2
https://lore.kernel.org/netdev/20230906093918.394a1b1d@hermes.local/

I probably also should have made sure that "iproute2" was in the subject 
prefix.

Hi Stephen, perhaps you can help with this?

Thanks,
sln


> 
> Thanks,
> -Siwei
> 
> 
> On Sat, May 13, 2023 at 12:42 AM Shannon Nelson <shannon.nelson@....com>
> wrote:
>  >
>  > From: Allen Hubbe <allen.hubbe@....com>
>  >
>  > Consume the parameter to device_features when parsing command line
>  > options.  Otherwise the parameter may be used again as an option name.
>  >
>  >  # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
>  >  Unknown option "0xdeadbeef"
>  >
>  > Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
>  > Signed-off-by: Allen Hubbe <allen.hubbe@....com>
>  > Reviewed-by: Shannon Nelson <shannon.nelson@....com>
> 
> Reviewed-by: Si-Wei Liu <si-wei.liu@...cle.com>
> 
>  > ---
>  >  vdpa/vdpa.c | 2 ++
>  >  1 file changed, 2 insertions(+)
>  >
>  > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
>  > index 27647d73d498..8a2fca8647b6 100644
>  > --- a/vdpa/vdpa.c
>  > +++ b/vdpa/vdpa.c
>  > @@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int
> argc, char **argv,
>  > &opts->device_features);
>  >                         if (err)
>  >                                 return err;
>  > +
>  > +                       NEXT_ARG_FWD();
>  >                         o_found |= VDPA_OPT_VDEV_FEATURES;
>  >                 } else {
>  >                         fprintf(stderr, "Unknown option \"%s\"\n",
> *argv);
>  > --
>  > 2.17.1
>  >
>