netdev - Re: [PATCH net] net: stmmac: Use hrtimer for TX coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c35a48ea40d7d7aeed81e29eb13af5562a481ab.camel@axis.com>
Date: Fri, 8 Sep 2023 10:42:22 +0000
From: Vincent Whitchurch <Vincent.Whitchurch@...s.com>
To: "peppe.cavallaro@...com" <peppe.cavallaro@...com>, "nbd@....name"
	<nbd@....name>, Vincent Whitchurch <Vincent.Whitchurch@...s.com>,
	"joabreu@...opsys.com" <joabreu@...opsys.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "alexandre.torgue@...com" <alexandre.torgue@...com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, kernel
	<kernel@...s.com>
Subject: Re: [PATCH net] net: stmmac: Use hrtimer for TX coalescing

On Fri, 2023-09-01 at 13:53 +0200, Felix Fietkau wrote:
> Could you please post your fix? I think in order to avoid accidental 
> breakage, we should make tx-usecs=0 imply tx-frames=1.

I've posted a fix to make tx-usecs=0 not use the timer.  The driver
already rejects the invalid setting of tx-frames=0 tx-usecs=0.

 https://lore.kernel.org/netdev/20230907-stmmac-coaloff-v2-1-38ccfac548b9@axis.com/