netdev - Re: [PATCH bpf-next 2/3] bpf: expose information about supported xdp metadata kfunc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 9 Sep 2023 19:23:14 +0800
From: kernel test robot <lkp@...el.com>
To: Stanislav Fomichev <sdf@...gle.com>, bpf@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, ast@...nel.org, daniel@...earbox.net,
	andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org,
	yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org,
	sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org,
	netdev@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH bpf-next 2/3] bpf: expose information about supported xdp
 metadata kfunc

Hi Stanislav,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/bpf-make-it-easier-to-add-new-metadata-kfunc/20230909-070017
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20230908225807.1780455-3-sdf%40google.com
patch subject: [PATCH bpf-next 2/3] bpf: expose information about supported xdp metadata kfunc
config: i386-randconfig-141-20230909 (https://download.01.org/0day-ci/archive/20230909/202309091923.UTfYFF4J-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230909/202309091923.UTfYFF4J-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309091923.UTfYFF4J-lkp@intel.com/

smatch warnings:
net/core/netdev-genl.c:26 netdev_nl_dev_fill() warn: inconsistent indenting

vim +26 net/core/netdev-genl.c

    11	
    12	static int
    13	netdev_nl_dev_fill(struct net_device *netdev, struct sk_buff *rsp,
    14			   const struct genl_info *info)
    15	{
    16		u64 xdp_rx_meta = 0;
    17		void *hdr;
    18	
    19		hdr = genlmsg_iput(rsp, info);
    20		if (!hdr)
    21			return -EMSGSIZE;
    22	
    23	#define XDP_METADATA_KFUNC(_, flag, __, xmo) \
    24		if (netdev->xdp_metadata_ops->xmo) \
    25			xdp_rx_meta |= flag;
  > 26	XDP_METADATA_KFUNC_xxx
    27	#undef XDP_METADATA_KFUNC
    28	
    29		if (nla_put_u32(rsp, NETDEV_A_DEV_IFINDEX, netdev->ifindex) ||
    30		    nla_put_u64_64bit(rsp, NETDEV_A_DEV_XDP_FEATURES,
    31				      netdev->xdp_features, NETDEV_A_DEV_PAD) ||
    32		    nla_put_u64_64bit(rsp, NETDEV_A_DEV_XDP_RX_METADATA_FEATURES,
    33				      xdp_rx_meta, NETDEV_A_DEV_PAD)) {
    34			genlmsg_cancel(rsp, hdr);
    35			return -EINVAL;
    36		}
    37	
    38		if (netdev->xdp_features & NETDEV_XDP_ACT_XSK_ZEROCOPY) {
    39			if (nla_put_u32(rsp, NETDEV_A_DEV_XDP_ZC_MAX_SEGS,
    40					netdev->xdp_zc_max_segs)) {
    41				genlmsg_cancel(rsp, hdr);
    42				return -EINVAL;
    43			}
    44		}
    45	
    46		genlmsg_end(rsp, hdr);
    47	
    48		return 0;
    49	}
    50	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki