netdev - Re: [PATCH net] net: nfc: llcp: Add lock when modifying device list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230910152812.GJ775887@kernel.org>
Date: Sun, 10 Sep 2023 17:28:12 +0200
From: Simon Horman <horms@...nel.org>
To: Jeremy Cline <jeremy@...ine.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	syzbot+c1d0a03d305972dbbe14@...kaller.appspotmail.com
Subject: Re: [PATCH net] net: nfc: llcp: Add lock when modifying device list

On Fri, Sep 08, 2023 at 07:58:53PM -0400, Jeremy Cline wrote:
> The device list needs its associated lock held when modifying it, or the
> list could become corrupted, as syzbot discovered.
> 
> Reported-and-tested-by: syzbot+c1d0a03d305972dbbe14@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=c1d0a03d305972dbbe14
> Signed-off-by: Jeremy Cline <jeremy@...ine.org>

Hi Jeremy,

thanks for your patch.

I don't think you need to resubmit for this,
I think this patch warrants a fixes tag:

Fixes: d646960f7986 ("NFC: Initial LLCP support")

Otherwise, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>