netdev - RE: [PATCH net 1/4] net: ena: Flush XDP packets on error.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed993d0d419443d2965015a504cb730b@amazon.com>
Date: Sun, 10 Sep 2023 07:42:14 +0000
From: "Kiyanovski, Arthur" <akiyano@...zon.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>
CC: "David S. Miller" <davem@...emloft.net>, Alexei Starovoitov
	<ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Jesper Dangaard
 Brouer" <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, "Paolo
 Abeni" <pabeni@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, "Arinzon,
 David" <darinzon@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, "Bshara,
 Saeed" <saeedb@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>
Subject: RE: [PATCH net 1/4] net: ena: Flush XDP packets on error.



> -----Original Message-----
> From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> Sent: Friday, September 8, 2023 4:58 PM
> To: netdev@...r.kernel.org; bpf@...r.kernel.org
> Cc: David S. Miller <davem@...emloft.net>; Alexei Starovoitov
> <ast@...nel.org>; Daniel Borkmann <daniel@...earbox.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Jesper
> Dangaard Brouer <hawk@...nel.org>; John Fastabend
> <john.fastabend@...il.com>; Paolo Abeni <pabeni@...hat.com>; Thomas
> Gleixner <tglx@...utronix.de>; Sebastian Andrzej Siewior
> <bigeasy@...utronix.de>; Kiyanovski, Arthur <akiyano@...zon.com>;
> Arinzon, David <darinzon@...zon.com>; Dagan, Noam
> <ndagan@...zon.com>; Bshara, Saeed <saeedb@...zon.com>; Agroskin,
> Shay <shayagr@...zon.com>
> Subject: [EXTERNAL] [PATCH net 1/4] net: ena: Flush XDP packets on error.
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> xdp_do_flush() should be invoked before leaving the NAPI poll function after
> a XDP-redirect. This is not the case if the driver leaves via the error path
> (after having a redirect in one of its previous iterations).
> 
> Invoke xdp_do_flush() also in the error path.
> 
> Cc: Arthur Kiyanovski <akiyano@...zon.com>
> Cc: David Arinzon <darinzon@...zon.com>
> Cc: Noam Dagan <ndagan@...zon.com>
> Cc: Saeed Bishara <saeedb@...zon.com>
> Cc: Shay Agroskin <shayagr@...zon.com>
> Fixes: a318c70ad152b ("net: ena: introduce XDP redirect implementation")
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index ad32ca81f7ef4..f955bde10cf90 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -1833,6 +1833,9 @@ static int ena_clean_rx_irq(struct ena_ring
> *rx_ring, struct napi_struct *napi,
>         return work_done;
> 
>  error:
> +       if (xdp_flags & ENA_XDP_REDIRECT)
> +               xdp_do_flush();
> +
>         adapter = netdev_priv(rx_ring->netdev);
> 
>         if (rc == -ENOSPC) {
> --
> 2.40.1
> 

Thanks for submitting this change.

Acked-by: Arthur Kiyanovski <akiyano@...zon.com>