netdev - Re: [PATCH net v2 1/2] i40e: fix potential memory leaks in i40e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa139383-6522-44ea-8f31-84161d60bde5@amd.com>
Date: Mon, 11 Sep 2023 13:41:54 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org
Cc: Andrii Staikov <andrii.staikov@...el.com>,
 Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
 Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net v2 1/2] i40e: fix potential memory leaks in
 i40e_remove()

On 9/11/2023 1:27 PM, Tony Nguyen wrote:
> 
> From: Andrii Staikov <andrii.staikov@...el.com>
> 
> Instead of freeing memory of a single VSI, make sure
> the memory for all VSIs is cleared before releasing VSIs.
> Add releasing of their resources in a loop with the iteration
> number equal to the number of allocated VSIs.
> 
> Fixes: 41c445ff0f48 ("i40e: main driver core")
> Signed-off-by: Andrii Staikov <andrii.staikov@...el.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Reviewed-by: Shannon Nelson <shannon.nelson@....com>

> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index de7fd43dc11c..00ca2b88165c 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -16320,11 +16320,15 @@ static void i40e_remove(struct pci_dev *pdev)
>                          i40e_switch_branch_release(pf->veb[i]);
>          }
> 
> -       /* Now we can shutdown the PF's VSI, just before we kill
> +       /* Now we can shutdown the PF's VSIs, just before we kill
>           * adminq and hmc.
>           */
> -       if (pf->vsi[pf->lan_vsi])
> -               i40e_vsi_release(pf->vsi[pf->lan_vsi]);
> +       for (i = pf->num_alloc_vsi; i--;)
> +               if (pf->vsi[i]) {
> +                       i40e_vsi_close(pf->vsi[i]);
> +                       i40e_vsi_release(pf->vsi[i]);
> +                       pf->vsi[i] = NULL;
> +               }
> 
>          i40e_cloud_filter_exit(pf);
> 
> --
> 2.38.1
>