netdev - Re: [PATCH iproute2-next] Enable automatic color output by default.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sf7l3sn8.fsf@nvidia.com>
Date: Mon, 11 Sep 2023 12:20:02 +0200
From: Petr Machata <petrm@...dia.com>
To: Sam Foxman <elasticvine@...tonmail.com>
CC: <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2-next] Enable automatic color output by default.

Sam Foxman <elasticvine@...tonmail.com> writes:

> Automatic color should be enabled by default because it makes command
> output much easier to read, especially `ip addr` with many interfaces.
> Color is enabled only in interactive use, scripts are not affected.

tc and bridge should do the same.

FWIW, `ls' on Fedora is aliased to `ls --color=auto' by default. My
guess is that the reason that it's not auto by default was the
performance hit resulting from having to stat every file.

iproute2 tools do not have that issue -- overhead from those escape
sequences must surely be noise? So it would IMHO make sense to default
to color output for iproute2 tools.

> ---
>  ip/ip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/ip.c b/ip/ip.c
> index 8c046ef1..aad6b6d7 100644
> --- a/ip/ip.c
> +++ b/ip/ip.c
> @@ -168,7 +168,7 @@ int main(int argc, char **argv)
>  	const char *libbpf_version;
>  	char *batch_file = NULL;
>  	char *basename;
> -	int color = 0;
> +	int color = COLOR_OPT_AUTO;
>  
>  	/* to run vrf exec without root, capabilities might be set, drop them
>  	 * if not needed as the first thing.