netdev - Re: [PATCH v4 3/4] net: stmmac: Add glue layer for Loongson-1 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c94138d2-1bfa-2815-a766-b7904e35a86f@linaro.org>
Date: Mon, 11 Sep 2023 12:48:05 +0200
From: Philippe Mathieu-Daudé <philmd@...aro.org>
To: Keguang Zhang <keguang.zhang@...il.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Giuseppe Cavallaro <peppe.cavallaro@...com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>,
 Serge Semin <Sergey.Semin@...kalelectronics.ru>
Subject: Re: [PATCH v4 3/4] net: stmmac: Add glue layer for Loongson-1 SoC

On 30/8/23 15:42, Keguang Zhang wrote:
> This glue driver is created based on the arch-code
> implemented earlier with the platform-specific settings.
> 
> Use syscon for SYSCON register access.
> 
> Partially based on the previous work by Serge Semin.
> 
> Signed-off-by: Keguang Zhang <keguang.zhang@...il.com>
> ---
> V3 -> V4: Drop ls1x_dwmac_syscon definition and its instances
>            Drop three redundant fields from the ls1x_dwmac structure
>            Drop the ls1x_dwmac_init() method.
>            Some minor improvements
> V2 -> V3: Determine the device ID by physical
>            base address(suggested by Serge Semin)
>            Use regmap instead of regmap fields
>            Use syscon_regmap_lookup_by_phandle()
>            Some minor fixes
> V1 -> V2: Fix the build errors due to CONFIG_OF being unset
>            Change struct reg_field definitions to const
>            Rename the syscon property to "loongson,dwmac-syscon"
>            Add MII PHY mode for LS1C
> 
>   drivers/net/ethernet/stmicro/stmmac/Kconfig   |  11 +
>   drivers/net/ethernet/stmicro/stmmac/Makefile  |   1 +
>   .../ethernet/stmicro/stmmac/dwmac-loongson1.c | 219 ++++++++++++++++++
>   3 files changed, 231 insertions(+)
>   create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c

Squash:

-- >8 --
diff --git a/MAINTAINERS b/MAINTAINERS
index ff1f273b4f36..2519d06b5aab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14344,9 +14344,12 @@ MIPS/LOONGSON1 ARCHITECTURE
  M:	Keguang Zhang <keguang.zhang@...il.com>
  L:	linux-mips@...r.kernel.org
  S:	Maintained
  F:	Documentation/devicetree/bindings/*/loongson,ls1x-*.yaml
  F:	Documentation/devicetree/bindings/net/loongson,ls1*.yaml
  F:	arch/mips/include/asm/mach-loongson32/
  F:	arch/mips/loongson32/
  F:	drivers/*/*loongson1*
+F:	drivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c
---