netdev - Re: [PATCH RESEND net-next v4 1/3] net: Add a bhash2 table hashed by port and address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Tue, 12 Sep 2023 00:06:32 +0000
From: "Iwashima, Kuniyuki" <kuniyu@...zon.co.jp>
To: Andrei Vagin <avagin@...il.com>, Joanne Koong <joannelkoong@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kafai@...com" <kafai@...com>, "kuba@...nel.org"
	<kuba@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "dccp@...r.kernel.org"
	<dccp@...r.kernel.org>, "Iwashima, Kuniyuki" <kuniyu@...zon.co.jp>
Subject: Re: [PATCH RESEND net-next v4 1/3] net: Add a bhash2 table hashed by
 port and address

From: Andrei Vagin <avagin@...il.com>
Date: Mon, 11 Sep 2023 16:36:55 -0700
> On Mon, Aug 22, 2022 at 11:10:21AM -0700, Joanne Koong wrote:
> >
> > +static bool inet_use_bhash2_on_bind(const struct sock *sk)
> > +{
> > +#if IS_ENABLED(CONFIG_IPV6)
> > +     if (sk->sk_family == AF_INET6) {
> > +             int addr_type = ipv6_addr_type(&sk->sk_v6_rcv_saddr);
> > +
> > +             return addr_type != IPV6_ADDR_ANY &&
> > +                     addr_type != IPV6_ADDR_MAPPED;
> >
> 
> Why do we return false to all mapped addresses? Should it be
> 
> (addr_type != IPV6_ADDR_MAPPED || sk->sk_rcv_saddr != htonl(INADDR_ANY))
> 

Yes, that could be done as optimisation.