netdev - Re: [REGRESSION] [PATCH net-next v5 2/2] net: stmmac: use per-queue 64 bit statistics where necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99695befef06b025de2c457ea5f861aa81a0883c.camel@pengutronix.de>
Date: Tue, 12 Sep 2023 11:04:16 +0200
From: Lucas Stach <l.stach@...gutronix.de>
To: Jisheng Zhang <jszhang@...nel.org>, Uwe Kleine-König
	 <u.kleine-koenig@...gutronix.de>
Cc: linux-kernel@...r.kernel.org, kernel@...gutronix.de, Samuel Holland
 <samuel@...lland.org>, netdev@...r.kernel.org, 
 linux-stm32@...md-mailman.stormreply.com, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Jernej Skrabec <jernej.skrabec@...il.com>, 
 Chen-Yu Tsai <wens@...e.org>, Eric Dumazet <edumazet@...gle.com>, Jose
 Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Jakub Kicinski <kuba@...nel.org>, Giuseppe Cavallaro
 <peppe.cavallaro@...com>, Paolo Abeni <pabeni@...hat.com>,
 linux-sunxi@...ts.linux.dev, "David S . Miller" <davem@...emloft.net>,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [REGRESSION] [PATCH net-next v5 2/2] net: stmmac: use per-queue
 64 bit statistics where necessary

Am Dienstag, dem 12.09.2023 um 16:01 +0800 schrieb Jisheng Zhang:
> On Mon, Sep 11, 2023 at 07:11:02PM +0200, Uwe Kleine-König wrote:
> > Hello,
> > 
> > this patch became commit 133466c3bbe171f826294161db203f7670bb30c8 and is
> > part of v6.6-rc1.
> > 
> > On my arm/stm32mp157 based machine using NFS root this commit makes the
> > following appear in the kernel log:
> > 
> > 	INFO: trying to register non-static key.
> > 	The code is fine but needs lockdep annotation, or maybe
> > 	you didn't initialize this object before use?
> > 	turning off the locking correctness validator.
> > 	CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc1-00449-g133466c3bbe1-dirty #21
> > 	Hardware name: STM32 (Device Tree Support)
> > 	 unwind_backtrace from show_stack+0x18/0x1c
> > 	 show_stack from dump_stack_lvl+0x60/0x90
> > 	 dump_stack_lvl from register_lock_class+0x98c/0x99c
> > 	 register_lock_class from __lock_acquire+0x74/0x293c
> > 	 __lock_acquire from lock_acquire+0x134/0x398
> > 	 lock_acquire from stmmac_get_stats64+0x2ac/0x2fc
> > 	 stmmac_get_stats64 from dev_get_stats+0x44/0x130
> > 	 dev_get_stats from rtnl_fill_stats+0x38/0x120
> > 	 rtnl_fill_stats from rtnl_fill_ifinfo+0x834/0x17f4
> > 	 rtnl_fill_ifinfo from rtmsg_ifinfo_build_skb+0xc0/0x144
> > 	 rtmsg_ifinfo_build_skb from rtmsg_ifinfo+0x50/0x88
> > 	 rtmsg_ifinfo from __dev_notify_flags+0xc0/0xec
> > 	 __dev_notify_flags from dev_change_flags+0x50/0x5c
> > 	 dev_change_flags from ip_auto_config+0x2f4/0x1260
> > 	 ip_auto_config from do_one_initcall+0x70/0x35c
> > 	 do_one_initcall from kernel_init_freeable+0x2ac/0x308
> > 	 kernel_init_freeable from kernel_init+0x1c/0x138
> > 	 kernel_init from ret_from_fork+0x14/0x2c
> > 	Exception stack(0xe0815fb0 to 0xe0815ff8)
> > 	5fa0:                                     00000000 00000000 00000000 00000000
> > 	5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> > 	5fe0: 00000000 00000000 00000000 00000000 00000013 00000000
> > 	dwc2 49000000.usb-otg: new device is high-speed
> > 
> > I didn't try understand this problem, it's too close to quitting time
> > :-)
> 
> Thanks for the bug report, I'm checking the code.

The newly added "struct u64_stats_sync syncp" uses a seqlock
internally, which is broken into multiple words on 32bit machines, and
needs to be initialized properly. You need to call u64_stats_init on
syncp before first usage.

Regards,
Lucas

> > 
> > Best regards
> > Uwe
> > 
> > -- 
> > Pengutronix e.K.                           | Uwe Kleine-König            |
> > Industrial Linux Solutions                 | https://www.pengutronix.de/ |
> 
> 
>