netdev - Re: [PATCH net-next 00/10] udp: round of data-races fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 12 Sep 2023 09:25:21 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Eric Dumazet <edumazet@...gle.com>, 
 "David S . Miller" <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, 
 eric.dumazet@...il.com, 
 Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 00/10] udp: round of data-races fixes

Eric Dumazet wrote:
> This series is inspired by multiple syzbot reports.
> 
> Many udp fields reads or writes are racy.
> 
> Add a proper udp->udp_flags and move there all
> flags needing atomic safety.
> 
> Also add missing READ_ONCE()/WRITE_ONCE() when
> lockless readers need access to specific fields.
> 
> Eric Dumazet (10):
>   udp: introduce udp->udp_flags
>   udp: move udp->no_check6_tx to udp->udp_flags
>   udp: move udp->no_check6_rx to udp->udp_flags
>   udp: move udp->gro_enabled to udp->udp_flags
>   udp: add missing WRITE_ONCE() around up->encap_rcv
>   udp: move udp->accept_udp_{l4|fraglist} to udp->udp_flags
>   udp: lockless UDP_ENCAP_L2TPINUDP / UDP_GRO
>   udp: annotate data-races around udp->encap_type
>   udplite: remove UDPLITE_BIT
>   udplite: fix various data-races
> 
>  drivers/net/gtp.c          |  4 +--
>  include/linux/udp.h        | 66 ++++++++++++++++++++--------------
>  include/net/udp_tunnel.h   |  9 ++---
>  include/net/udplite.h      | 14 +++++---
>  net/ipv4/udp.c             | 74 +++++++++++++++++++-------------------
>  net/ipv4/udp_offload.c     |  4 +--
>  net/ipv4/udp_tunnel_core.c |  2 +-
>  net/ipv4/udplite.c         |  1 -
>  net/ipv4/xfrm4_input.c     |  4 +--
>  net/ipv6/udp.c             | 34 +++++++++---------
>  net/ipv6/udplite.c         |  1 -
>  net/ipv6/xfrm6_input.c     |  4 +--
>  net/l2tp/l2tp_core.c       |  6 ++--
>  13 files changed, 118 insertions(+), 105 deletions(-)

For the series:

Reviewed-by: Willem de Bruijn <willemb@...gle.com>