netdev - Re: [PATCH iproute2] vdpa: consume device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 12 Sep 2023 11:18:16 +0800
From: Jason Wang <jasowang@...hat.com>
To: Shannon Nelson <shannon.nelson@....com>
Cc: dsahern@...nel.org, netdev@...r.kernel.org, 
	virtualization@...ts.linux-foundation.org, mst@...hat.com, 
	si-wei.liu@...cle.com, allen.hubbe@....com, drivers@...sando.io
Subject: Re: [PATCH iproute2] vdpa: consume device_features parameter

On Tue, Sep 12, 2023 at 2:08 AM Shannon Nelson <shannon.nelson@....com> wrote:
>
> From: Allen Hubbe <allen.hubbe@....com>
>
> Consume the parameter to device_features when parsing command line
> options.  Otherwise the parameter may be used again as an option name.
>
>  # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55
>  Unknown option "0xdeadbeef"
>
> Fixes: a4442ce58ebb ("vdpa: allow provisioning device features")
> Signed-off-by: Allen Hubbe <allen.hubbe@....com>
> Reviewed-by: Shannon Nelson <shannon.nelson@....com>
> Reviewed-by: Si-Wei Liu <si-wei.liu@...cle.com>

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks

> ---
>  vdpa/vdpa.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
> index 8bbe452c..6e4a9c11 100644
> --- a/vdpa/vdpa.c
> +++ b/vdpa/vdpa.c
> @@ -353,6 +353,8 @@ static int vdpa_argv_parse(struct vdpa *vdpa, int argc, char **argv,
>                                                 &opts->device_features);
>                         if (err)
>                                 return err;
> +
> +                       NEXT_ARG_FWD();
>                         o_found |= VDPA_OPT_VDEV_FEATURES;
>                 } else {
>                         fprintf(stderr, "Unknown option \"%s\"\n", *argv);
> --
> 2.17.1
>