netdev - RE: [PATCH net-next 1/6] net: stmmac: add platform library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <DM4PR12MB5088F83CE829184956147E6BD3F1A@DM4PR12MB5088.namprd12.prod.outlook.com>
Date: Tue, 12 Sep 2023 07:59:49 +0000
From: Jose Abreu <Jose.Abreu@...opsys.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Alexandre Torgue
	<alexandre.torgue@...s.st.com>
CC: Alexei Starovoitov <ast@...nel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S.  Miller" <davem@...emloft.net>,
        Emil Renner Berthing <kernel@...il.dk>,
        Eric Dumazet <edumazet@...gle.com>, Fabio Estevam <festevam@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
        "linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        NXP Linux Team <linux-imx@....com>, Paolo Abeni <pabeni@...hat.com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Samin Guo <samin.guo@...rfivetech.com>,
        Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>,
        Jose Abreu <Jose.Abreu@...opsys.com>
Subject: RE: [PATCH net-next 1/6] net: stmmac: add platform library

From: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
Date: Mon, Sep 11, 2023 at 16:28:40

> Add a platform library of helper functions for common traits in the
> platform drivers. Currently, this is setting the tx clock.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/ethernet/stmicro/stmmac/Makefile  |  2 +-
>  .../ethernet/stmicro/stmmac/stmmac_plat_lib.c | 29 +++++++++++++++++++
>  .../ethernet/stmicro/stmmac/stmmac_plat_lib.h |  8 +++++

Wouldn't it be better to just call it "stmmac_lib{.c,.h}" in case we need to add
more helpers on the future that are not only for platform-based drivers?

I believe it's also missing the SPDX identifiers?

Thanks,
Jose