netdev - Re: [Intel-wired-lan] [PATCH iwl-net v2] igc: Fix infinite initialization loop with early XDP redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f9e7d31-7c73-e5c1-b34c-3924c5d6b100@linux.intel.com>
Date: Wed, 13 Sep 2023 13:56:10 +0300
From: "naamax.meir" <naamax.meir@...ux.intel.com>
To: Vinicius Costa Gomes <vinicius.gomes@...el.com>,
 intel-wired-lan@...ts.osuosl.org
Cc: Andre Guedes <andre.guedes@...el.com>, netdev@...r.kernel.org,
 Jesse Brandeburg <jesse.brandeburg@...el.com>,
 Jithu Joseph <jithu.joseph@...el.com>, linux-kernel@...r.kernel.org,
 Ferenc Fejes <ferenc.fejes@...csson.com>, Eric Dumazet
 <edumazet@...gle.com>, Tony Nguyen <anthony.l.nguyen@...el.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 "David S. Miller" <davem@...emloft.net>,
 Vedang Patel <vedang.patel@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] igc: Fix infinite
 initialization loop with early XDP redirect

On 9/7/2023 03:30, Vinicius Costa Gomes wrote:
> When a XDP redirect happens before the link is ready, that
> transmission will not finish and will timeout, causing an adapter
> reset. If the redirects do not stop, the adapter will not stop
> resetting.
> 
> Wait for the driver to signal that there's a carrier before allowing
> transmissions to proceed.
> 
> Previous code was relying that when __IGC_DOWN is cleared, the NIC is
> ready to transmit as all the queues are ready, what happens is that
> the carrier presence will only be signaled later, after the watchdog
> workqueue has a chance to run. And during this interval (between
> clearing __IGC_DOWN and the watchdog running) if any transmission
> happens the timeout is emitted (detected by igc_tx_timeout()) which
> causes the reset, with the potential for the inifite loop.
> 
> Fixes: 4ff320361092 ("igc: Add support for XDP_REDIRECT action")
> Reported-by: Ferenc Fejes <ferenc.fejes@...csson.com>
> Closes: https://lore.kernel.org/netdev/0caf33cf6adb3a5bf137eeaa20e89b167c9986d5.camel@ericsson.com/
> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
> Tested-by: Ferenc Fejes <ferenc.fejes@...csson.com>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
> v1 -> v2:
>   - Added more information to the commit message (Maciej Fijalkowski)
> 
> 
>   drivers/net/ethernet/intel/igc/igc_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by: Naama Meir <naamax.meir@...ux.intel.com>