netdev - Re: [REGRESSION] [PATCH net-next v5 2/2] net: stmmac: use per-queue 64 bit statistics where necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27579950c5a5f9221e7b52524cbc8de97d8b90e0.camel@sipsolutions.net>
Date: Wed, 13 Sep 2023 16:49:39 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
 Lucas Stach <l.stach@...gutronix.de>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Eric Dumazet <edumazet@...gle.com>, Samuel
 Holland <samuel@...lland.org>,  netdev@...r.kernel.org, "David S . Miller"
 <davem@...emloft.net>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jernej Skrabec <jernej.skrabec@...il.com>,  linux-kernel@...r.kernel.org,
 Chen-Yu Tsai <wens@...e.org>, Jose Abreu <joabreu@...opsys.com>,
 kernel@...gutronix.de, Giuseppe Cavallaro <peppe.cavallaro@...com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 linux-sunxi@...ts.linux.dev,  linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [REGRESSION] [PATCH net-next v5 2/2] net: stmmac: use per-queue
 64 bit statistics where necessary

On Wed, 2023-09-13 at 22:34 +0800, Jisheng Zhang wrote:
> 
> Since we are in rc1, I need to fix the bug with as small changes as
> possible. so another solution could be: replace rx/tx stats structure
> with pointers, then setup pointers in the new allocated dma_conf with
> the old one as current code did for dma_tx_size/dma_rx_size in
> stmmac_setup_dma_desc():
> 
> dma_conf->dma_tx_size = priv->dma_conf.dma_tx_size
> 
> Is it acceptable?

I'm not sure who you're asking of all the people in this thread, but I
honestly don't understand much about this driver other than what I
gleaned in the few minutes looking at it with Uwe ... so I don't think
I'm able to answer that question :)

You could also just move the stats out of the structure entirely, I
guess? And perhaps even start some new structure where more things might
move in the future that shouldn't be reallocated?

I'm all for not moving things now that haven't caused problems, but I
guess doing a minimal fix just for the sake of being minimal in -rc1
wouldn't be my preference.

johannes