lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <b05b3230-488b-4cb5-a154-c80e53870440@gmail.com> Date: Wed, 13 Sep 2023 08:52:08 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Linus Walleij <linus.walleij@...aro.org>, Alvin Šipraga <alsi@...g-olufsen.dk>, Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next] net: dsa: rtl8366rb: Implement setting up link on CPU port On 9/12/2023 2:24 PM, Linus Walleij wrote: > We auto-negotiate most ports in the RTL8366RB driver, but > the CPU port is hard-coded to 1Gbit, full duplex, tx and > rx pause. > > This isn't very nice. People may configure speed and > duplex differently in the device tree. > > Actually respect the arguments passed to the function for > the CPU port, which get passed properly after Russell's > patch "net: dsa: realtek: add phylink_get_caps implementation" > > After this the link is still set up properly. > > Signed-off-by: Linus Walleij <linus.walleij@...aro.org> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com> -- Florian
Powered by blists - more mailing lists