netdev - Re: [PATCH v2] net: thunderbolt: Fix TCPv6 GSO checksum calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLA-iba+D5SYxWKYAR1pbo8+qp5w88Q-Xs2KcdFV9JTyA@mail.gmail.com>
Date: Wed, 13 Sep 2023 07:55:54 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: Michael Jamet <michael.jamet@...el.com>, Yehezkel Bernat <YehezkelShB@...il.com>, 
	"David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Alex Balcanquall <alex@...xbal.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: thunderbolt: Fix TCPv6 GSO checksum calculation

On Wed, Sep 13, 2023 at 7:26 AM Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
>
> Alex reported that running ssh over IPv6 does not work with
> Thunderbolt/USB4 networking driver. The reason for that is that driver
> should call skb_is_gso() before calling skb_is_gso_v6(), and it should
> not return false after calculates the checksum successfully. This probably
> was a copy paste error from the original driver where it was done properly.
>
> Reported-by: Alex Balcanquall <alex@...xbal.com>
> Fixes: e69b6c02b4c3 ("net: Add support for networking over Thunderbolt cable")
> Cc: stable@...r.kernel.org
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !