lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <nzguzjuchyk5uwdnexegayweyogv5wdfgaxrrw47fuw2rjkumq@4ybro57ixsga> Date: Thu, 14 Sep 2023 15:06:17 +0200 From: Stefano Garzarella <sgarzare@...hat.com> To: Arseniy Krasnov <avkrasnov@...utedevices.com> Cc: Stefan Hajnoczi <stefanha@...hat.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Bobby Eshleman <bobby.eshleman@...edance.com>, kvm@...r.kernel.org, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...rdevices.ru, oxffffaa@...il.com Subject: Re: [PATCH net-next v8 2/4] vsock/virtio: support to send non-linear skb On Mon, Sep 11, 2023 at 11:22:32PM +0300, Arseniy Krasnov wrote: >For non-linear skb use its pages from fragment array as buffers in >virtio tx queue. These pages are already pinned by 'get_user_pages()' >during such skb creation. > >Signed-off-by: Arseniy Krasnov <avkrasnov@...utedevices.com> >--- > Changelog: > v2 -> v3: > * Comment about 'page_to_virt()' is updated. I don't remove R-b, > as this change is quiet small I guess. > v6 -> v7: > * Move arrays '*sgs' and 'bufs' to 'virtio_vsock' instead of being > local variables. This allows to save stack space in cases of too > big MAX_SKB_FRAGS. > * Add 'WARN_ON_ONCE()' for handling nonlinear skbs - it checks that > linear part of such skb contains only header. > * R-b tag removed due to updates above. > v7 -> v8: > * Add comment in 'struct virtio_vsock' for both 'struct scatterlist' > fields. > * Rename '*sgs' and 'bufs' to '*out_sgs' and 'out_bufs'. > * Initialize '*out_sgs' in 'virtio_vsock_probe()' by always pointing > to the corresponding element of 'out_bufs'. LGTM, thanks for addressing that comments! > > net/vmw_vsock/virtio_transport.c | 60 ++++++++++++++++++++++++++++---- > 1 file changed, 53 insertions(+), 7 deletions(-) Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>
Powered by blists - more mailing lists