netdev - Re: [PATCH v2 1/1] net: core: Use the bitmap API to allocate bitmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38b363e7-0ffc-a319-0003-97fbfb0c7501@intel.com>
Date: Thu, 14 Sep 2023 16:01:14 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Sergey Ryazanov <ryazanov.s.a@...il.com>, Simon Horman
	<horms@...nel.org>
Subject: Re: [PATCH v2 1/1] net: core: Use the bitmap API to allocate bitmaps

On 9/13/23 13:09, Andy Shevchenko wrote:
> Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> It is less verbose and it improves the type checking and semantic.
> 
> While at it, add missing header inclusion (should be bitops.h,
> but with the above change it becomes bitmap.h).
> 
> Suggested-by: Sergey Ryazanov <ryazanov.s.a@...il.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Link: https://lore.kernel.org/r/20230911154534.4174265-1-andriy.shevchenko@linux.intel.com
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> v2: added tags (Simon), sent separately from the series (Paolo)

Yeah, in any context it's hard to get people to agree to fix things when 
they started out of order :~

>   net/core/dev.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index ccff2b6ef958..85df22f05c38 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -69,7 +69,7 @@
>    */
>   
>   #include <linux/uaccess.h>
> -#include <linux/bitops.h>
> +#include <linux/bitmap.h>
>   #include <linux/capability.h>
>   #include <linux/cpu.h>
>   #include <linux/types.h>
> @@ -1080,7 +1080,7 @@ static int __dev_alloc_name(struct net *net, const char *name, char *buf)
>   			return -EINVAL;
>   
>   		/* Use one page as a bit array of possible slots */
> -		inuse = (unsigned long *) get_zeroed_page(GFP_ATOMIC);
> +		inuse = bitmap_zalloc(max_netdevices, GFP_ATOMIC);
>   		if (!inuse)
>   			return -ENOMEM;
>   
> @@ -1109,7 +1109,7 @@ static int __dev_alloc_name(struct net *net, const char *name, char *buf)
>   		}
>   
>   		i = find_first_zero_bit(inuse, max_netdevices);
> -		free_page((unsigned long) inuse);
> +		bitmap_free(inuse);
>   	}
>   
>   	snprintf(buf, IFNAMSIZ, name, i);

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>