netdev - Re: [PATCH net-next 02/14] ipv6: lockless IPV6_MULTICAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa0b8610-0cc1-7b42-8a6b-a45ec3e7e610@kernel.org>
Date: Thu, 14 Sep 2023 08:54:09 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 02/14] ipv6: lockless IPV6_MULTICAST_LOOP
 implementation

On 9/12/23 10:02 AM, Eric Dumazet wrote:
> Add inet6_{test|set|clear|assign}_bit() helpers.
> 
> Note that I am using bits from inet->inet_flags,
> this might change in the future if we need more flags.
> 
> While solving data-races accessing np->mc_loop,
> this patch also allows to implement lockless accesses
> to np->mcast_hops in the following patch.
> 
> Also constify sk_mc_loop() argument.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  include/linux/ipv6.h            | 18 ++++++++++++++----
>  include/net/inet_sock.h         |  1 +
>  include/net/sock.h              |  2 +-
>  net/core/sock.c                 |  4 ++--
>  net/ipv6/af_inet6.c             |  2 +-
>  net/ipv6/ipv6_sockglue.c        | 18 ++++++++----------
>  net/ipv6/ndisc.c                |  2 +-
>  net/netfilter/ipvs/ip_vs_sync.c |  8 ++------
>  8 files changed, 30 insertions(+), 25 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>