netdev - Re: [PATCH net-next 14/14] ipv6: lockless IPV6_FLOWINFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 14 Sep 2023 09:11:11 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 14/14] ipv6: lockless IPV6_FLOWINFO_SEND
 implementation

On 9/12/23 10:02 AM, Eric Dumazet wrote:
> np->sndflow reads are racy.
> 
> Use one bit ftom atomic inet->inet_flags instead,
> IPV6_FLOWINFO_SEND setsockopt() can be lockless.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  include/linux/ipv6.h     |  3 +--
>  include/net/inet_sock.h  |  1 +
>  net/dccp/ipv6.c          |  2 +-
>  net/ipv4/ping.c          |  3 +--
>  net/ipv6/af_inet6.c      |  2 +-
>  net/ipv6/datagram.c      |  7 ++++---
>  net/ipv6/ipv6_sockglue.c | 13 ++++++-------
>  net/ipv6/ping.c          |  2 +-
>  net/ipv6/raw.c           |  2 +-
>  net/ipv6/tcp_ipv6.c      |  2 +-
>  net/ipv6/udp.c           |  2 +-
>  net/l2tp/l2tp_ip6.c      |  4 ++--
>  net/sctp/ipv6.c          |  3 ++-
>  13 files changed, 23 insertions(+), 23 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>