netdev - Re: [RFC bpf-next 12/23] xdp: Add checksum hint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <280ca32f-4c69-dd5b-fd9b-e69a7685a60a@intel.com>
Date: Thu, 14 Sep 2023 18:34:40 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Larysa Zaremba <larysa.zaremba@...el.com>, <bpf@...r.kernel.org>
CC: <ast@...nel.org>, <daniel@...earbox.net>, <andrii@...nel.org>,
	<martin.lau@...ux.dev>, <song@...nel.org>, <yhs@...com>,
	<john.fastabend@...il.com>, <kpsingh@...nel.org>, <sdf@...gle.com>,
	<haoluo@...gle.com>, <jolsa@...nel.org>, David Ahern <dsahern@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Willem de Bruijn <willemb@...gle.com>,
	Jesper Dangaard Brouer <brouer@...hat.com>, Anatoly Burakov
	<anatoly.burakov@...el.com>, Alexander Lobakin <alexandr.lobakin@...el.com>,
	Magnus Karlsson <magnus.karlsson@...il.com>, Maryam Tahhan
	<mtahhan@...hat.com>, <xdp-hints@...-project.net>, <netdev@...r.kernel.org>,
	Willem de Bruijn <willemdebruijn.kernel@...il.com>, Alexei Starovoitov
	<alexei.starovoitov@...il.com>, Simon Horman <simon.horman@...igine.com>,
	Tariq Toukan <tariqt@...lanox.com>, Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [RFC bpf-next 12/23] xdp: Add checksum hint

From: Larysa Zaremba <larysa.zaremba@...el.com>
Date: Thu, 24 Aug 2023 21:26:51 +0200

> Implement functionality that enables drivers to expose to XDP code checksum
> information that consists of:
> 
> - Checksum status - 2 non-exlusive flags:
>   - XDP_CHECKSUM_VERIFIED indicating HW has validated the checksum
>     (corresponding to CHECKSUM_UNNECESSARY in sk_buff)
>   - XDP_CHECKSUM_COMPLETE signifies the validity of the second argument
>     (corresponding to CHECKSUM_COMPLETE in sk_buff)
> - Checksum, calculated over the entire packet, valid if the second flag is
>   set
> 
> Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Only one stupid thing from me: when a line starts from '-' in the commit
message, some editors/viewers paint it red thinking it's a diff already
:z (same for '+')
Not something important, you just may want to prefer "neutral" '*', up
to you :D

> ---
>  Documentation/networking/xdp-rx-metadata.rst |  3 +++
>  include/net/xdp.h                            | 15 +++++++++++++
>  kernel/bpf/offload.c                         |  2 ++
>  net/core/xdp.c                               | 23 ++++++++++++++++++++
>  4 files changed, 43 insertions(+)

[...]

Thanks,
Olek