netdev - Re: [PATCH net-next 6/7] net: phy: split locked and unlocked section of phy_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1f54186-e5f3-77d1-0fe8-4a5fd58cc635@gmail.com>
Date: Thu, 14 Sep 2023 11:39:07 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: chenhao418@...wei.com, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Jijie Shao <shaojijie@...wei.com>, lanhao@...wei.com,
 liuyonglong@...wei.com, netdev@...r.kernel.org,
 Paolo Abeni <pabeni@...hat.com>, shenjian15@...wei.com,
 wangjie125@...wei.com, wangpeiyang1@...wei.com
Subject: Re: [PATCH net-next 6/7] net: phy: split locked and unlocked section
 of phy_state_machine()

On 9/14/23 08:35, Russell King (Oracle) wrote:
> Split out the locked and unlocked sections of phy_state_machine() into
> two separate functions which can be called inside the phydev lock and
> outside the phydev lock as appropriate, thus allowing us to combine
> the locked regions in the caller of phy_state_machine() with the
> locked region inside phy_state_machine().
> 
> This avoids unnecessarily dropping the phydev lock which may allow
> races to occur.
> 
> Tested-by: Jijie Shao <shaojijie@...wei.com>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian