netdev - Re: [PATCH v2] net: thunderbolt: Fix TCPv6 GSO checksum calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN2PR18MB2574E41CCCBA6CD612D8AFE6DAF7A@MN2PR18MB2574.namprd18.prod.outlook.com>
Date: Thu, 14 Sep 2023 01:20:20 +0000
From: Alex Balcanquall <alex@...xbal.com>
To: Jiri Pirko <jiri@...nulli.us>, Mika Westerberg
	<mika.westerberg@...ux.intel.com>
CC: Michael Jamet <michael.jamet@...el.com>, Yehezkel Bernat
	<YehezkelShB@...il.com>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] net: thunderbolt: Fix TCPv6 GSO checksum calculation

Thanks, the v2 patch worked perfectly on my 3 test machines.

From: Jiri Pirko <jiri@...nulli.us>
Sent: Wednesday, September 13, 2023 12:51 AM
To: Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc: Michael Jamet <michael.jamet@...el.com>; Yehezkel Bernat <YehezkelShB@...il.com>; David S . Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Alex Balcanquall <alex@...xbal.com>; netdev@...r.kernel.org <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] net: thunderbolt: Fix TCPv6 GSO checksum calculation 

Wed, Sep 13, 2023 at 07:26:47AM CEST, mika.westerberg@...ux.intel.com wrote:
>Alex reported that running ssh over IPv6 does not work with
>Thunderbolt/USB4 networking driver. The reason for that is that driver
>should call skb_is_gso() before calling skb_is_gso_v6(), and it should
>not return false after calculates the checksum successfully. This probably
>was a copy paste error from the original driver where it was done properly.
>
>Reported-by: Alex Balcanquall <alex@...xbal.com>
>Fixes: e69b6c02b4c3 ("net: Add support for networking over Thunderbolt cable")
>Cc: stable@...r.kernel.org

Interesting, it is not actually cced. No need to do it anyway.

>Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>