lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7bg6suzboq6jocyf6ozrfcjpbehm3j3ttkag3few5hgeziliu6@abyv2qpucy2w> Date: Thu, 14 Sep 2023 15:06:59 +0300 From: Serge Semin <fancer.lancer@...il.com> To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Alexei Starovoitov <ast@...nel.org>, bpf@...r.kernel.org, Daniel Borkmann <daniel@...earbox.net>, "David S. Miller" <davem@...emloft.net>, Emil Renner Berthing <kernel@...il.dk>, Eric Dumazet <edumazet@...gle.com>, Fabio Estevam <festevam@...il.com>, Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, linux-arm-kernel@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com, Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, NXP Linux Team <linux-imx@....com>, Paolo Abeni <pabeni@...hat.com>, Pengutronix Kernel Team <kernel@...gutronix.de>, Samin Guo <samin.guo@...rfivetech.com>, Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org> Subject: Re: [PATCH net-next 3/6] net: stmmac: intel-plat: use dwmac_set_tx_clk_gmii() On Mon, Sep 11, 2023 at 04:29:21PM +0100, Russell King (Oracle) wrote: > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk> > --- > .../stmicro/stmmac/dwmac-intel-plat.c | 35 +++++-------------- > 1 file changed, 9 insertions(+), 26 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > index d352a14f9d48..8cc22f11072e 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c > @@ -14,6 +14,7 @@ > #include "dwmac4.h" > #include "stmmac.h" > #include "stmmac_platform.h" > +#include "stmmac_plat_lib.h" > > struct intel_dwmac { > struct device *dev; > @@ -31,32 +32,14 @@ struct intel_dwmac_data { > static void kmb_eth_fix_mac_speed(void *priv, unsigned int speed, unsigned int mode) > { > struct intel_dwmac *dwmac = priv; > - unsigned long rate; > - int ret; > - > - rate = clk_get_rate(dwmac->tx_clk); > - > - switch (speed) { > - case SPEED_1000: > - rate = 125000000; > - break; > - > - case SPEED_100: > - rate = 25000000; > - break; > - > - case SPEED_10: > - rate = 2500000; > - break; > - > - default: > - dev_err(dwmac->dev, "Invalid speed\n"); > - break; > - } > - > - ret = clk_set_rate(dwmac->tx_clk, rate); > - if (ret) > - dev_err(dwmac->dev, "Failed to configure tx clock rate\n"); > + int err; > + > + err = dwmac_set_tx_clk_gmii(dwmac->tx_clk, speed); > + if (err == -ENOTSUPP) > + dev_err(dwmac->dev, "invalid speed %dMbps\n", speed); '%u'? > + else if (err) > + dev_err(dwmac->dev, "failed to set tx rate for speed %dMbps: %pe\n", ditto -Serge(y) > + speed, ERR_PTR(err)); > } > > static const struct intel_dwmac_data kmb_data = { > -- > 2.30.2 > >
Powered by blists - more mailing lists