netdev - Re: [PATCH net-next 10/15] net: ethernet: mtk_wed: introduce WED support for MT7988

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQSGQH5n78e0wpz7@lore-desk>
Date: Fri, 15 Sep 2023 18:28:48 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: netdev@...r.kernel.org, lorenzo.bianconi@...hat.com, nbd@....name,
	john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, daniel@...rotopia.org,
	linux-mediatek@...ts.infradead.org, sujuan.chen@...iatek.com,
	krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 10/15] net: ethernet: mtk_wed: introduce WED
 support for MT7988

> On Thu, Sep 14, 2023 at 04:38:15PM +0200, Lorenzo Bianconi wrote:
> > From: Sujuan Chen <sujuan.chen@...iatek.com>
> > 
> > Similar to MT7986 and MT7622, enable Wireless Ethernet Ditpatcher for
[...]
> > -	ring_size = dev->wlan.nbuf & ~(MTK_WED_BUF_PER_PAGE - 1);
> > -	n_pages = ring_size / MTK_WED_BUF_PER_PAGE;
> > +	if (!mtk_wed_is_v3_or_greater(dev->hw)) {
> > +		dev->tx_buf_ring.desc_size = sizeof(struct mtk_wdma_desc);
> 
> Instead of checking the version or using of_device_is_compatible() in 
> other places why don't you define driver match data for all this static 
> data.

ack, I will look into it.

Regards,
Lorenzo

> 
> Rob

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)