netdev - Re: [PATCH] net: sched: hfsc: dont intepret cls results when asked to drop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202309160007.7615P5Df-lkp@intel.com>
Date: Sat, 16 Sep 2023 00:27:51 +0800
From: kernel test robot <lkp@...el.com>
To: Ma Ke <make_ruc2021@....com>, jhs@...atatu.com,
	xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Ma Ke <make_ruc2021@....com>
Subject: Re: [PATCH] net: sched: hfsc: dont intepret cls results when asked
 to drop

Hi Ma,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]
[also build test WARNING on net/main linus/master v6.6-rc1 next-20230915]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ma-Ke/net-sched-hfsc-dont-intepret-cls-results-when-asked-to-drop/20230915-214635
base:   net-next/main
patch link:    https://lore.kernel.org/r/20230915134408.3410595-1-make_ruc2021%40163.com
patch subject: [PATCH] net: sched: hfsc: dont intepret cls results when asked to drop
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230916/202309160007.7615P5Df-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230916/202309160007.7615P5Df-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309160007.7615P5Df-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/compiler_types.h:80,
                    from <command-line>:
   net/sched/sch_hfsc.c: In function 'hfsc_classify':
>> include/linux/compiler_attributes.h:227:41: warning: attribute 'fallthrough' not preceding a case label or default label
     227 | # define fallthrough                    __attribute__((__fallthrough__))
         |                                         ^~~~~~~~~~~~~
   net/sched/sch_hfsc.c:1146:25: note: in expansion of macro 'fallthrough'
    1146 |                         fallthrough;
         |                         ^~~~~~~~~~~


vim +/fallthrough +227 include/linux/compiler_attributes.h

294f69e662d157 Joe Perches   2019-10-05  214  
294f69e662d157 Joe Perches   2019-10-05  215  /*
294f69e662d157 Joe Perches   2019-10-05  216   * Add the pseudo keyword 'fallthrough' so case statement blocks
294f69e662d157 Joe Perches   2019-10-05  217   * must end with any of these keywords:
294f69e662d157 Joe Perches   2019-10-05  218   *   break;
294f69e662d157 Joe Perches   2019-10-05  219   *   fallthrough;
ca0760e7d79e2b Wei Ming Chen 2021-05-06  220   *   continue;
294f69e662d157 Joe Perches   2019-10-05  221   *   goto <label>;
294f69e662d157 Joe Perches   2019-10-05  222   *   return [expression];
294f69e662d157 Joe Perches   2019-10-05  223   *
294f69e662d157 Joe Perches   2019-10-05  224   *  gcc: https://gcc.gnu.org/onlinedocs/gcc/Statement-Attributes.html#Statement-Attributes
294f69e662d157 Joe Perches   2019-10-05  225   */
294f69e662d157 Joe Perches   2019-10-05  226  #if __has_attribute(__fallthrough__)
294f69e662d157 Joe Perches   2019-10-05 @227  # define fallthrough                    __attribute__((__fallthrough__))
294f69e662d157 Joe Perches   2019-10-05  228  #else
294f69e662d157 Joe Perches   2019-10-05  229  # define fallthrough                    do {} while (0)  /* fallthrough */
a3f8a30f3f0079 Miguel Ojeda  2018-08-30  230  #endif
a3f8a30f3f0079 Miguel Ojeda  2018-08-30  231  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki