netdev - Re: [PATCH v1 net-next 2/5] net-smnp: reorganize SNMP fast path variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2367db17-c5e9-4853-b607-8e84d90044b4@lunn.ch>
Date: Sat, 16 Sep 2023 16:39:36 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Coco Li <lixiaoyan@...gle.com>
Cc: Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Mubashir Adnan Qureshi <mubashirq@...gle.com>,
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
	Chao Wu <wwchao@...gle.com>, Wei Wang <weiwan@...gle.com>
Subject: Re: [PATCH v1 net-next 2/5] net-smnp: reorganize SNMP fast path
 variables

> diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
> index 26f33a4c253d7..a414985c68bf9 100644
> --- a/include/uapi/linux/snmp.h
> +++ b/include/uapi/linux/snmp.h

UAPI. Warning bells are ringing.

> @@ -170,6 +170,22 @@ enum
>  enum
>  {
>  	LINUX_MIB_NUM = 0,
> +	/* TX hotpath */
> +	LINUX_MIB_TCPAUTOCORKING,		/* TCPAutoCorking */
> +	LINUX_MIB_TCPFROMZEROWINDOWADV,		/* TCPFromZeroWindowAdv */
> +	LINUX_MIB_TCPTOZEROWINDOWADV,		/* TCPToZeroWindowAdv */
> +	LINUX_MIB_TCPWANTZEROWINDOWADV,		/* TCPWantZeroWindowAdv */
> +	LINUX_MIB_TCPORIGDATASENT,		/* TCPOrigDataSent */
> +	LINUX_MIB_TCPPUREACKS,			/* TCPPureAcks */
> +	LINUX_MIB_TCPHPACKS,			/* TCPHPAcks */
> +	LINUX_MIB_TCPDELIVERED,			/* TCPDelivered */
> +	/* RX hotpath */
> +	LINUX_MIB_TCPHPHITS,			/* TCPHPHits */
> +	LINUX_MIB_TCPRCVCOALESCE,		/* TCPRcvCoalesce */
> +	LINUX_MIB_TCPKEEPALIVE,			/* TCPKeepAlive */
> +	LINUX_MIB_DELAYEDACKS,			/* DelayedACKs */
> +	LINUX_MIB_DELAYEDACKLOCKED,		/* DelayedACKLocked */
> +	/* End of hotpath variables */

At a first glance, this appears to change the kernel ABI?

Or am i wrong?

	Andrew