Message-Id: <169487631004.1637924.11195328221220782623.robh@kernel.org>
Date: Sat, 16 Sep 2023 09:58:30 -0500
From: Rob Herring <robh@...nel.org>
To: Arınç ÜNAL <arinc.unal@...nc9.com>
Cc: Landen Chao <Landen.Chao@...iatek.com>, DENG Qingfang <dqfext@...il.com>, Claudiu Manoil <claudiu.manoil@....com>, mithat.guner@...ont.com, Woojung Huh <Woojung.Huh@...rochip.com>, George McCollister <george.mccollister@...il.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Oleksij Rempel <linux@...pel-privat.de>, Grygorii Strashko <grygorii.strashko@...com>, Kurt Kanzenbach <kurt@...utronix.de>, Steen Hegelund <steen.hegelund@...rochip.com>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Sekhar Nori <nsekhar@...com>, linux-mediatek@...ts.infradead.org, John Crispin <john@...ozen.org>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, "David S. Miller" <davem@...emloft.net>, Alexandre Belloni <alexandre.belloni@...tlin.com>, Paolo Abeni <pabeni@...hat.com>, Linus Walleij <linus.walleij@...aro.org>, Radhey Shyam Pandey <radhey.shyam.pandey@....com>, linux-renesas-soc@...r.kernel.org, Magnus Damm <magnus.damm@...i
 l.com>, Lars Povlsen <lars.povlsen@...rochip.com>, Marek Vasut <marex@...x.de>, Jose Abreu <joabreu@...opsys.com>, Jakub Kicinski <kuba@...nel.org>, Vladimir Oltean <olteanv@...il.com>, Claudiu Beznea <claudiu.beznea@...rochip.com>, netdev@...r.kernel.org, Shyam Pandey <radhey.shyam.pandey@...inx.com>, Maxime Chevallier <maxime.chevallier@...tlin.com>, "Russell King (Oracle)" <linux@...linux.org.uk>, Ioana Ciornei <ioana.ciornei@....com>, linux-arm-kernel@...ts.infradead.org, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, erkin.bozoglu@...ont.com, Steen Hegelund <Steen.Hegelund@...rochip.com>, Lorenzo Bianconi <lorenzo@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Matthias Brugger <matthias.bgg@...il.com>, Marcin Wojtas <mw@...ihalf.com>, Felix Fietkau <nbd@....name>, Horatiu Vultur <horatiu.vultur@...rochip.com>, Eric Dumazet <edumazet@...gle.com>, Madalin Bucur <madalin.bucur@....com>, Andrew Lunn <andrew@...n.ch>, Woojun
 g Huh <woojung.huh@...rochip.com>, Alvin Šipraga <alsi@...g-olufsen.dk>, Daniel Golle <daniel@...rotopia.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Sean Wang <sean.wang@...iatek.com>, Daniel Machon <daniel.machon@...rochip.com>, Rob Herring <robh+dt@...nel.org>, Florian Fainelli <f.fainelli@...il.com>, Clément Léger <clement.leger@...tlin.com>, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next v2 08/10] dt-bindings: net: dsa: marvell:
 convert to json-schema


On Sat, 16 Sep 2023 14:09:00 +0300, Arınç ÜNAL wrote:
> Convert the document for Marvell ethernet switches to json-schema.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
>  .../devicetree/bindings/net/dsa/marvell.txt   | 109 ----------
>  .../devicetree/bindings/net/dsa/marvell.yaml  | 204 ++++++++++++++++++
>  2 files changed, 204 insertions(+), 109 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/net/dsa/marvell.txt
>  create mode 100644 Documentation/devicetree/bindings/net/dsa/marvell.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: switch@0: ports: '#address-cells' is a required property
	from schema $id: http://devicetree.org/schemas/net/dsa/marvell.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: switch@0: ports: '#size-cells' is a required property
	from schema $id: http://devicetree.org/schemas/net/dsa/marvell.yaml#
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 966, in resolve_fragment
    document = document[part]
               ~~~~~~~~^^^^^^
KeyError: '$defs'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/dt-validate", line 146, in <module>
    sg.check_dtb(filename)
  File "/usr/local/bin/dt-validate", line 96, in check_dtb
    self.check_subtree(dt, subtree, False, "/", "/", filename)
  File "/usr/local/bin/dt-validate", line 89, in check_subtree
    self.check_subtree(tree, value, disabled, name, fullname + name, filename)
  File "/usr/local/bin/dt-validate", line 89, in check_subtree
    self.check_subtree(tree, value, disabled, name, fullname + name, filename)
  File "/usr/local/bin/dt-validate", line 89, in check_subtree
    self.check_subtree(tree, value, disabled, name, fullname + name, filename)
  File "/usr/local/bin/dt-validate", line 84, in check_subtree
    self.check_node(tree, subtree, disabled, nodename, fullname, filename)
  File "/usr/local/bin/dt-validate", line 40, in check_node
    for error in self.validator.iter_errors(node, filter=match_schema_file):
  File "/usr/local/lib/python3.11/dist-packages/dtschema/validator.py", line 391, in iter_errors
    for error in self.DtValidator(sch,
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 288, in iter_errors
    for error in errors:
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/_validators.py", line 414, in if_
    yield from validator.descend(instance, then, schema_path="then")
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 305, in descend
    for error in self.evolve(schema=schema).iter_errors(instance):
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 288, in iter_errors
    for error in errors:
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/_validators.py", line 362, in allOf
    yield from validator.descend(instance, subschema, schema_path=index)
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 305, in descend
    for error in self.evolve(schema=schema).iter_errors(instance):
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 288, in iter_errors
    for error in errors:
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/_validators.py", line 414, in if_
    yield from validator.descend(instance, then, schema_path="then")
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 305, in descend
    for error in self.evolve(schema=schema).iter_errors(instance):
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 288, in iter_errors
    for error in errors:
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/_validators.py", line 25, in patternProperties
    yield from validator.descend(
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 305, in descend
    for error in self.evolve(schema=schema).iter_errors(instance):
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 288, in iter_errors
    for error in errors:
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/_validators.py", line 25, in patternProperties
    yield from validator.descend(
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 305, in descend
    for error in self.evolve(schema=schema).iter_errors(instance):
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 288, in iter_errors
    for error in errors:
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/_validators.py", line 294, in ref
    scope, resolved = validator.resolver.resolve(ref)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 898, in resolve
    return url, self._remote_cache(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 916, in resolve_from_url
    return self.resolve_fragment(document, fragment)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/jsonschema/validators.py", line 968, in resolve_fragment
    raise exceptions.RefResolutionError(
jsonschema.exceptions.RefResolutionError: Unresolvable JSON pointer: '$defs/phylink'

doc reference errors (make refcheckdocs):
Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/net/dsa/marvell.txt
MAINTAINERS: Documentation/devicetree/bindings/net/dsa/marvell.txt

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230916110902.234273-9-arinc.unal@arinc9.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Powered by blists - more mailing lists