netdev - Re: nft_rhash_walk, rhashtable and resize event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Sep 2023 08:38:09 -0400
From: Alexander Aring <aahringo@...hat.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Pablo Neira Ayuso <pablo@...filter.org>, Network Development <netdev@...r.kernel.org>, kadlec@...filter.org, 
	fw@...len.de, gfs2@...ts.linux.dev, David Teigland <teigland@...hat.com>, tgraf@...g.ch
Subject: Re: nft_rhash_walk, rhashtable and resize event

Hi,

On Mon, Sep 18, 2023 at 8:26 AM Herbert Xu <herbert@...dor.apana.org.au> wrote:
>
> On Mon, Sep 18, 2023 at 01:59:47PM +0200, Pablo Neira Ayuso wrote:
> >
> > One more question: this walk might miss entries but may it also
> > duplicate the same entries?
>
> It depends on what happens during the walk.  If you're lucky
> and no resize event occurs during the walk, then you won't miss
> any entries or see duplicates.
>
> When a resize event does occur, then we will tell you that it
> happened by returning EAGAIN.  It means that you should start
> from the beginning and redo the whole walk.  If you do that

To confirm this, redo the whole walk means starting at
rhashtable_walk_start() again?

Thanks.

- Alex