netdev - Re: [PATCH v2 net] dccp: fix dccp_v4_err()/dccp_v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <169501802239.15865.14994267231326012591.git-patchwork-notify@kernel.org>
Date: Mon, 18 Sep 2023 06:20:22 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, eric.dumazet@...il.com, syzkaller@...glegroups.com,
 jannh@...gle.com
Subject: Re: [PATCH v2 net] dccp: fix dccp_v4_err()/dccp_v6_err() again

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Fri, 15 Sep 2023 19:00:35 +0000 you wrote:
> dh->dccph_x is the 9th byte (offset 8) in "struct dccp_hdr",
> not in the "byte 7" as Jann claimed.
> 
> We need to make sure the ICMP messages are big enough,
> using more standard ways (no more assumptions).
> 
> syzbot reported:
> BUG: KMSAN: uninit-value in pskb_may_pull_reason include/linux/skbuff.h:2667 [inline]
> BUG: KMSAN: uninit-value in pskb_may_pull include/linux/skbuff.h:2681 [inline]
> BUG: KMSAN: uninit-value in dccp_v6_err+0x426/0x1aa0 net/dccp/ipv6.c:94
> pskb_may_pull_reason include/linux/skbuff.h:2667 [inline]
> pskb_may_pull include/linux/skbuff.h:2681 [inline]
> dccp_v6_err+0x426/0x1aa0 net/dccp/ipv6.c:94
> icmpv6_notify+0x4c7/0x880 net/ipv6/icmp.c:867
> icmpv6_rcv+0x19d5/0x30d0
> ip6_protocol_deliver_rcu+0xda6/0x2a60 net/ipv6/ip6_input.c:438
> ip6_input_finish net/ipv6/ip6_input.c:483 [inline]
> NF_HOOK include/linux/netfilter.h:304 [inline]
> ip6_input+0x15d/0x430 net/ipv6/ip6_input.c:492
> ip6_mc_input+0xa7e/0xc80 net/ipv6/ip6_input.c:586
> dst_input include/net/dst.h:468 [inline]
> ip6_rcv_finish+0x5db/0x870 net/ipv6/ip6_input.c:79
> NF_HOOK include/linux/netfilter.h:304 [inline]
> ipv6_rcv+0xda/0x390 net/ipv6/ip6_input.c:310
> __netif_receive_skb_one_core net/core/dev.c:5523 [inline]
> __netif_receive_skb+0x1a6/0x5a0 net/core/dev.c:5637
> netif_receive_skb_internal net/core/dev.c:5723 [inline]
> netif_receive_skb+0x58/0x660 net/core/dev.c:5782
> tun_rx_batched+0x83b/0x920
> tun_get_user+0x564c/0x6940 drivers/net/tun.c:2002
> tun_chr_write_iter+0x3af/0x5d0 drivers/net/tun.c:2048
> call_write_iter include/linux/fs.h:1985 [inline]
> new_sync_write fs/read_write.c:491 [inline]
> vfs_write+0x8ef/0x15c0 fs/read_write.c:584
> ksys_write+0x20f/0x4c0 fs/read_write.c:637
> __do_sys_write fs/read_write.c:649 [inline]
> __se_sys_write fs/read_write.c:646 [inline]
> __x64_sys_write+0x93/0xd0 fs/read_write.c:646
> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
> entry_SYSCALL_64_after_hwframe+0x63/0xcd
> 
> [...]

Here is the summary with links:
  - [v2,net] dccp: fix dccp_v4_err()/dccp_v6_err() again
    https://git.kernel.org/netdev/net/c/6af289746a63

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html