| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4481c437-3d78-0ae9-d2ce-c12de09c1a98@gmail.com> Date: Mon, 18 Sep 2023 13:53:55 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: netdev@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH net-next 9/9] net: dsa: vitesse-vsc73xx: Convert to platform remove callback returning void On 9/18/23 12:19, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() is renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com> -- Florian
Powered by blists - more mailing lists