netdev - Re: [PATCH net-next 13/15] net: ethernet: mtk_wed: introduce hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZQgCLIUUbX51eV+R@lore-desk>
Date: Mon, 18 Sep 2023 09:54:20 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, lorenzo.bianconi@...hat.com, nbd@....name,
	john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, daniel@...rotopia.org,
	linux-mediatek@...ts.infradead.org, sujuan.chen@...iatek.com,
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 13/15] net: ethernet: mtk_wed: introduce hw_rro
 support for MT7988

[...]
> > +
> > +			buf += MTK_WED_PAGE_BUF_SIZE;
> 
> clang-16 W=1 warns that buf is set but otherwise unused in this function.

Hi Simon,

ack, I will fix it.

Regards,
Lorenzo

> 
> > +			buf_phys += MTK_WED_PAGE_BUF_SIZE;
> > +		}
> > +
> > +		dma_sync_single_for_device(dev->hw->dev, page_phys, PAGE_SIZE,
> > +					   DMA_BIDIRECTIONAL);
> > +	}
> > +
> > +	return 0;
> > +}
> > +
> >  static int
> >  mtk_wed_rx_buffer_alloc(struct mtk_wed_device *dev)
> >  {
> 
> ...

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)