netdev - Re: [PATCH net] vxlan: Add missing entries to vxlan_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQm8W9O6WLZ+G5QM@shredder>
Date: Tue, 19 Sep 2023 18:20:59 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Ido Schimmel <idosch@...dia.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>,
	Simon Horman <horms@...nel.org>, Jiri Benc <jbenc@...hat.com>,
	Gavin Li <gavinl@...dia.com>, Hangbin Liu <liuhangbin@...il.com>,
	Vladimir Nikishkin <vladimir@...ishkin.pw>,
	Li Zetao <lizetao1@...wei.com>, Thomas Graf <tgraf@...g.ch>,
	Tom Herbert <therbert@...gle.com>, Roopa Prabhu <roopa@...dia.com>
Subject: Re: [PATCH net] vxlan: Add missing entries to vxlan_get_size()

On Mon, Sep 18, 2023 at 11:40:15AM -0400, Benjamin Poirier wrote:
> There are some attributes added by vxlan_fill_info() which are not
> accounted for in vxlan_get_size(). Add them.
> 
> I didn't find a way to trigger an actual problem from this miscalculation
> since there is usually extra space in netlink size calculations like
> if_nlmsg_size(); but maybe I just didn't search long enough.
> 
> Fixes: 3511494ce2f3 ("vxlan: Group Policy extension")
> Fixes: e1e5314de08b ("vxlan: implement GPE")
> Fixes: 0ace2ca89cbd ("vxlan: Use checksum partial with remote checksum offload")
> Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device")
> Signed-off-by: Benjamin Poirier <bpoirier@...dia.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>