netdev - Re: [PATCH net-next 41/54] net: ethernet: renesas: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Sep 2023 20:28:06 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Geert Uytterhoeven <geert+renesas@...der.be>, Yoshihiro Shimoda
	<yoshihiro.shimoda.uh@...esas.com>, Simon Horman <horms@...nel.org>, Wolfram
 Sang <wsa+renesas@...g-engineering.com>, Biju Das
	<biju.das.jz@...renesas.com>, Alexander Duyck <alexanderduyck@...com>,
	Michael Walle <michael@...le.cc>, Rob Herring <robh@...nel.org>, Andrew Lunn
	<andrew@...n.ch>, <netdev@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>, <kernel@...gutronix.de>
Subject: Re: [PATCH net-next 41/54] net: ethernet: renesas: Convert to
 platform remove callback returning void

Hello!

On 9/18/23 11:42 PM, Uwe Kleine-König wrote:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
> 
> Trivially convert these drivers from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
[...]
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index ea9186178091..3c165b15709f 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c

   Hm, I still need to do a patch clarifying that I don't do rswitch reviews --
I'm not familiar with that hardware and don't have the manuals ATM...

[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey